Re: [PATCH] platform/chrome: cros_ec: Expose suspend_timeout in debugfs

[Prashant Malani]

Hi Evan,

On Fri, Aug 5, 2022 at 3:17 PM Evan Green <evgreen@xxxxxxxxxxxx> wrote:
>
> diff --git a/drivers/platform/chrome/cros_ec_debugfs.c b/drivers/platform/chrome/cros_ec_debugfs.c
> index 0dbceee87a4b1a..530378bd4359dd 100644
> --- a/drivers/platform/chrome/cros_ec_debugfs.c
> +++ b/drivers/platform/chrome/cros_ec_debugfs.c
> @@ -470,6 +470,9 @@ static int cros_ec_debugfs_probe(struct platform_device *pd)
>         debugfs_create_x32("last_resume_result", 0444, debug_info->dir,
>                            &ec->ec_dev->last_resume_result);
>
> +       debugfs_create_u16("suspend_timeout", 0664, debug_info->dir,
> +                          &ec->ec_dev->suspend_timeout);

Can we call this "suspend_timeout_ms" instead? That makes it clear what the
units being used are.

BR,

- Prashant