Re: [RFC PATCH 1/6] dt-bindings: crypto: ti,sa2ul: add pka subdevice

[Krzysztof Kozlowski]

On 08/08/2022 22:12, Daniel Parks wrote:
> The PKA (aka eip29t2) is a subdevice of the SA2UL on k3.
> 
> Signed-off-by: Daniel Parks <danielrparks@xxxxxx>
> ---
>  Documentation/devicetree/bindings/crypto/ti,sa2ul.yaml | 6 ++++++
>  1 file changed, 6 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/crypto/ti,sa2ul.yaml b/Documentation/devicetree/bindings/crypto/ti,sa2ul.yaml
> index 02f47c2e7998..e4adb8192608 100644
> --- a/Documentation/devicetree/bindings/crypto/ti,sa2ul.yaml
> +++ b/Documentation/devicetree/bindings/crypto/ti,sa2ul.yaml
> @@ -64,8 +64,14 @@ patternProperties:
>      type: object
>      description:
>        Child RNG node for SA2UL
>  
> +patternProperties:
> +  "^pka@[a-f0-9]+$":
> +    type: object
> +    description:
> +      Child PKA node for SA2UL

If PKA is from "Public Key Accelerator", could you include here full
name of the abbreviation?

Anyway you need here reference to schema for your node or describe the
contents.

Best regards,
Krzysztof