Re: [PATCH v3 2/2] KVM: x86/xen: Stop Xen timer before changing IRQ
From: David Woodhouse
Date: Tue Aug 09 2022 - 05:22:45 EST
On Mon, 2022-08-08 at 14:06 -0500, Coleman Dietsch wrote:
> Stop Xen timer (if it's running) prior to changing the IRQ vector and
> potentially (re)starting the timer. Changing the IRQ vector while the
> timer is still running can result in KVM injecting a garbage event, e.g.
> vm_xen_inject_timer_irqs() could see a non-zero xen.timer_pending from
> a previous timer but inject the new xen.timer_virq.
Hm, wasn't that already addressed in the first patch I saw, which just
called kvm_xen_stop_timer() unconditionally before (possibly) setting
it up again?
Attachment:
smime.p7s
Description: S/MIME cryptographic signature