Re: [PATCH 3/8] remoteproc: qcom: Add compatible name for SC7280 ADSP

[Srinivasa Rao Mandadapu]

On 8/7/2022 2:27 AM, Dmitry Baryshkov wrote:
Thanks for Your Time Dimtry!!!
> On 03/08/2022 17:21, Srinivasa Rao Mandadapu wrote:
> > Update adsp pil data and compatible name for loading ADSP
> > binary on SC7280 based platforms.
> >
> > Signed-off-by: Srinivasa Rao Mandadapu <quic_srivasam@xxxxxxxxxxx>
> > ---
> >   drivers/remoteproc/qcom_q6v5_adsp.c | 19 +++++++++++++++++++
> >   1 file changed, 19 insertions(+)
> >
> > diff --git a/drivers/remoteproc/qcom_q6v5_adsp.c 
> > b/drivers/remoteproc/qcom_q6v5_adsp.c
> > index 2f3b9f5..bb4494c 100644
> > --- a/drivers/remoteproc/qcom_q6v5_adsp.c
> > +++ b/drivers/remoteproc/qcom_q6v5_adsp.c
> > @@ -697,6 +697,24 @@ static const struct adsp_pil_data 
> > adsp_resource_init = {
> >       },
> >   };
> >   +static const struct adsp_pil_data adsp_sc7280_resource_init = {
> > +    .crash_reason_smem = 423,
> > +    .firmware_name = "adsp.mbn",
> > +    .load_state = "adsp",
> > +    .ssr_name = "lpass",
> > +    .sysmon_name = "adsp",
> > +    .ssctl_id = 0x14,
> > +    .is_wpss = false,
> > +    .auto_boot = true,
> > +    .clk_ids = (const char*[]) {
> > +        "gcc_cfg_noc_lpass", NULL
>
> The clock is not mentioned in dt bindings.
Will update in dt bindings and re post it.
> > +    },
> > +    .num_clks = 1,
> > +    .proxy_pd_names = (const char*[]) {
> > +        NULL
> > +    },
>
> Is the empty array necessary?
Okay. Will remove it.
> > +};
> > +
> >   static const struct adsp_pil_data cdsp_resource_init = {
> >       .crash_reason_smem = 601,
> >       .firmware_name = "cdsp.mdt",
> > @@ -737,6 +755,7 @@ static const struct of_device_id adsp_of_match[] = {
> >       { .compatible = "qcom,qcs404-cdsp-pil", .data = 
> > &cdsp_resource_init },
> >       { .compatible = "qcom,sc7280-wpss-pil", .data = 
> > &wpss_resource_init },
> >       { .compatible = "qcom,sdm845-adsp-pil", .data = 
> > &adsp_resource_init },
> > +    { .compatible = "qcom,sc7280-adsp-pil", .data = 
> > &adsp_sc7280_resource_init },
> >       { },
> >   };
> >   MODULE_DEVICE_TABLE(of, adsp_of_match);