Re: [RFC PATCH 2/5] entry: Add calls for save/restore auxiliary pt_regs

[Borislav Petkov]

On Fri, Aug 05, 2022 at 10:30:06AM -0700, ira.weiny@xxxxxxxxx wrote:
> From: Ira Weiny <ira.weiny@xxxxxxxxx>
> 
> Some architectures have auxiliary pt_regs space available to store
> information on the stack during exceptions.  This information is easier
> to obtain and store within C code rather than in arch specific assembly.

There are others?

Because I would've done this whole thing in arch/x86/ only...

> diff --git a/kernel/entry/common.c b/kernel/entry/common.c
> index 8c0f334c4b75..a70a0f314aee 100644
> --- a/kernel/entry/common.c
> +++ b/kernel/entry/common.c
> @@ -317,7 +317,7 @@ noinstr irqentry_state_t irqentry_enter(struct pt_regs *regs)
>  
>  	if (user_mode(regs)) {
>  		irqentry_enter_from_user_mode(regs);
> -		return ret;
> +		goto aux_save;

Why do you have to goto and do the instrumentation sandwitch around it
at the goto label?

Why not simply do

	if (user_mode(regs)) {
		irqentry_enter_from_user_mode(regs);
		arch_save_aux_pt_regs(regs);
		return ret;

and so on?

Thx.

-- 
Regards/Gruss,
    Boris.

https://people.kernel.org/tglx/notes-about-netiquette