Re: [PATCH v2 2/3] arm64: dts: qcom: sa8295p: move common nodes to dtsi

[Parikshit Pareek]

On Tue, Jul 26, 2022 at 03:49:26PM +0200, Johan Hovold wrote:
> On Fri, Jul 22, 2022 at 08:02:32PM +0530, Parikshit Pareek wrote:
> > There are many ADP boards with lot of common features. Move common
> > nodes to sa8xxxp-auto.dtsi files. This will be base for many ADP boards
> > to be introduced in near future.
> > 
> > Signed-off-by: Parikshit Pareek <quic_ppareek@xxxxxxxxxxx>
> > ---
> > 
> > Changes since v1:
> > - Add , after year 2022, in the license header
> > - Rename the dtsi which is suitable for common to many ADP boards
> > - Split the patch in introducing common dtsi file, and adding new board
> >   file
> > 
> >  arch/arm64/boot/dts/qcom/sa8295p-adp.dts      | 378 +----------------
> >  .../arm64/boot/dts/qcom/sa8xxxp-auto-adp.dtsi | 385 ++++++++++++++++++
> >  2 files changed, 387 insertions(+), 376 deletions(-)
> >  create mode 100644 arch/arm64/boot/dts/qcom/sa8xxxp-auto-adp.dtsi
> 
> Not sure about the name; sa8540-adp.dtsi seems like a better choice, but
> I'd need to know more about how these two relate to each other.
> 
> What differs between sa8295p-adp and sa8540p-adp? That should go in the
> commit message too.
The sa8540-adp has connectors for PCIe,ethernet-switch and different USB ports than sa8295p-adp.
So far, as we checked, such differences are on connector level and don't need any device tree level
modification. If any is needed, intention is to do that in future patches.
> 
> > diff --git a/arch/arm64/boot/dts/qcom/sa8295p-adp.dts b/arch/arm64/boot/dts/qcom/sa8295p-adp.dts
> > index 9398f0349944..3cc92162ba02 100644
> > --- a/arch/arm64/boot/dts/qcom/sa8295p-adp.dts
> > +++ b/arch/arm64/boot/dts/qcom/sa8295p-adp.dts
> > @@ -2,388 +2,14 @@
> >  /*
> >   * Copyright (c) 2021, The Linux Foundation. All rights reserved.
> >   * Copyright (c) 2022, Linaro Limited
> > + * Copyright (c) 2022, Qualcomm Innovation Center, Inc. All rights reserved.
> 
> I'm pretty sure you can't claim copyright for just moving code around
> (same for the new file).
> 
> >   */
> 
> Johan
Regards,
Parikshit Pareek