On 09/08/2022 22:42, Eddie James wrote:
no-scan-on-init is not a good example. It wasn't even reviewed by Rob+ ibm,inactive-on-init:I find the combination property name with this description confusing. It
+ description: This property describes whether or not the OCC should
+ be marked as active during device initialization. The alternative
+ is for user space to mark the device active based on higher level
+ communications between the BMC and the host processor.
sounds like init of OCC and somehow it should be inactive? I assume if
you initialize device, it is active. Or maybe the "init" is of something
else? What is more, non-negation is easier to understand, so rather
"ibm,active-on-boot" (or something like that).
Well, the host processor initializes the OCC during it's boot, but this
document is describing a binding to be used by a service processor
talking to the OCC. So the OCC may be in any state. The init meant
driver init, but I will simply the description and change the property
to be more explicit: ibm,no-poll-on-init since that is what is actually
happening. Similar to the FSI binding for no-scan-on-init.
(looking at commit). In both cases you describe driver behavior which is
not appropriate for bindings. Instead you should describe the hardware
characteristics/feature/bug/state which require skipping the initialization.
Best regards,
Krzysztof