Re: [PATCH v2 0/4] drm/amd: Add more GFXOFF stats for vangogh

From: André Almeida
Date: Wed Aug 10 2022 - 12:02:39 EST




Às 12:57 de 10/08/22, Alex Deucher escreveu:
> On Tue, Jul 26, 2022 at 2:23 PM André Almeida <andrealmeid@xxxxxxxxxx> wrote:
>>
>> This series adds new logging features for GFXOFF available for vangogh
>> and documentation for it.
>>
>> I've created a small userspace program to interact with this new debugfs
>> interface and it can be found at:
>>
>> https://gitlab.freedesktop.org/andrealmeid/gfxoff_tool
>>
>> Changelog:
>> v2:
>> - Make entrycount uint64_t
>> - Add a note in docs about data types and overflow
>
> A minor comment on patch 2, the rest looks good to me.
>

ok, let me send a v3

> Thanks,
>
> Alex
>
>
>>
>> André Almeida (4):
>> drm/amd: Add detailed GFXOFF stats to debugfs
>> drm/amd/pm: Implement GFXOFF's entry count and residency for vangogh
>> Documentation/gpu: Document GFXOFF's count and residency
>> drm/amdgpu: Document gfx_off members of struct amdgpu_gfx
>>
>> Documentation/gpu/amdgpu/thermal.rst | 18 +-
>> drivers/gpu/drm/amd/amdgpu/amdgpu_debugfs.c | 168 ++++++++++++++++++
>> drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 2 +
>> drivers/gpu/drm/amd/amdgpu/amdgpu_gfx.c | 39 ++++
>> drivers/gpu/drm/amd/amdgpu/amdgpu_gfx.h | 14 +-
>> drivers/gpu/drm/amd/pm/amdgpu_dpm.c | 45 +++++
>> drivers/gpu/drm/amd/pm/inc/amdgpu_dpm.h | 3 +
>> drivers/gpu/drm/amd/pm/swsmu/amdgpu_smu.c | 35 +++-
>> drivers/gpu/drm/amd/pm/swsmu/inc/amdgpu_smu.h | 22 +++
>> .../pm/swsmu/inc/pmfw_if/smu_v11_5_ppsmc.h | 5 +-
>> drivers/gpu/drm/amd/pm/swsmu/inc/smu_types.h | 5 +-
>> .../gpu/drm/amd/pm/swsmu/smu11/vangogh_ppt.c | 92 ++++++++++
>> drivers/gpu/drm/amd/pm/swsmu/smu_internal.h | 3 +
>> 13 files changed, 443 insertions(+), 8 deletions(-)
>>
>> --
>> 2.37.1
>>