Re: [PATCH] x86/apic: Don't disable x2APIC if locked

From: Dave Hansen
Date: Wed Aug 10 2022 - 19:44:23 EST


On 8/10/22 16:38, Daniel Sneddon wrote:
>>
>> config INTEL_TDX_GUEST
>> bool "Intel TDX (Trust Domain Extensions) - Guest Support"
>> depends on X86_64 && CPU_SUP_INTEL
>> depends on X86_X2APIC
> So I got some more input. SPR and newer will lock the APIC.

Could you get a _little_ more clarity on this, please? Exactly how and
when will it be locked? What does the BIOS writer's guide say? Will
there be an explicit x2APIC lock option? Or, will it be implicitly
locked when SGX or TDX is enabled?

> Older products will get a ucode update, but that ucode update won't
> include the APIClock. So, on non-SPR parts do we still want to make
> SGX depend on X2APIC?
Yes. It's a small price to pay.