Re: [PATCH v3 3/8] remoteproc: qcom: Add flag in adsp private data structure
From: Stephen Boyd
Date: Wed Aug 10 2022 - 20:17:42 EST
Quoting Srinivasa Rao Mandadapu (2022-08-10 00:45:53)
> Add flag in qcom_adsp private data structure and initialize
> it to distinguish ADSP and WPSS modules.
>
> Signed-off-by: Srinivasa Rao Mandadapu <quic_srivasam@xxxxxxxxxxx>
> ---
> Changes since V2:
> -- Add is_adsp_sb_needed flag instead of is_wpss.
>
> drivers/remoteproc/qcom_q6v5_adsp.c | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/drivers/remoteproc/qcom_q6v5_adsp.c b/drivers/remoteproc/qcom_q6v5_adsp.c
> index 2f3b9f5..d18ec74 100644
> --- a/drivers/remoteproc/qcom_q6v5_adsp.c
> +++ b/drivers/remoteproc/qcom_q6v5_adsp.c
> @@ -62,6 +62,7 @@ struct adsp_pil_data {
> const char *sysmon_name;
> int ssctl_id;
> bool is_wpss;
> + bool is_adsp_sb_needed;
What does 'sb' mean? Self boot? Can you just write it out? And maybe
drop 'is_' prefix because if (is_*) and if (something_needed) reads the
same.