Re: 回复: [PATCH] ACPI: APEI: move edac_init ahead of ghes platform drv register
From: Borislav Petkov
Date: Thu Aug 11 2022 - 03:40:50 EST
On Thu, Aug 11, 2022 at 12:39:10AM +0000, Justin He wrote:
> > +static int __init ghes_edac_init(void)
> > +{
> > + struct ghes *g, *g_tmp;
> > +
> > + ghes_devs = ghes_get_devices(force_load);
> > + if (ghes_devs)
> Should it be changed to if(!ghes_devs) ?
> Otherwise, this ghes_edac_init() on Arm will always return with ENODEV
> because ! ghes_get_devices().
Yes, of course, sorry about that.
I mean, for a lack of a better idea, it returns a list of devices... ;-\
Thx.
--
Regards/Gruss,
Boris.
https://people.kernel.org/tglx/notes-about-netiquette