Re: [PATCH v3 1/4] dt-bindings: clock: mediatek: add bindings for MT8365 SoC

[Krzysztof Kozlowski]

On 11/08/2022 11:44, Markus Schneider-Pargmann wrote:
> From: Fabien Parent <fparent@xxxxxxxxxxxx>
> 
> Add the clock bindings for the MediaTek MT8365 SoC.
> 
> Signed-off-by: Fabien Parent <fparent@xxxxxxxxxxxx>
> Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx>
> Signed-off-by: Markus Schneider-Pargmann <msp@xxxxxxxxxxxx>
> ---
>  .../bindings/clock/mediatek,mt8365-clock.yaml |  42 ++
>  .../clock/mediatek,mt8365-sys-clock.yaml      |  47 +++
>  .../dt-bindings/clock/mediatek,mt8365-clk.h   | 374 ++++++++++++++++++
>  3 files changed, 463 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/clock/mediatek,mt8365-clock.yaml
>  create mode 100644 Documentation/devicetree/bindings/clock/mediatek,mt8365-sys-clock.yaml
>  create mode 100644 include/dt-bindings/clock/mediatek,mt8365-clk.h
> 
> diff --git a/Documentation/devicetree/bindings/clock/mediatek,mt8365-clock.yaml b/Documentation/devicetree/bindings/clock/mediatek,mt8365-clock.yaml
> new file mode 100644
> index 000000000000..31cd248e772b
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/clock/mediatek,mt8365-clock.yaml
> @@ -0,0 +1,42 @@
> +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: "http://devicetree.org/schemas/clock/mediatek,mt8365-clock.yaml#";
> +$schema: "http://devicetree.org/meta-schemas/core.yaml#";

No quotes needed in both lines.

> +
> +title: MediaTek Functional Clock Controller for MT8365
> +
> +maintainers:
> +  - Fabien Parent <fparent@xxxxxxxxxxxx>

Are you sure this is correct and working email? Let's try not to add
non-existing emails to Git maintainers. It's a bit of pain to fix it
later. :/

> +
> +properties:
> +  compatible:
> +    items:
> +      - enum:
> +          - mediatek,mt8365-apu
> +          - mediatek,mt8365-imgsys
> +          - mediatek,mt8365-mfgcfg
> +          - mediatek,mt8365-vdecsys
> +          - mediatek,mt8365-vencsys
> +      - const: syscon
> +
> +  reg:
> +    maxItems: 1
> +
> +  '#clock-cells':
> +    const: 1
> +
> +required:
> +  - compatible
> +  - reg
> +  - '#clock-cells'
> +
> +additionalProperties: false
> +
> +examples:
> +  - |
> +    apu: clock-controller@19020000 {
> +        compatible = "mediatek,mt8365-apu", "syscon";
> +        reg = <0x19020000 0x1000>;
> +        #clock-cells = <1>;
> +    };
> diff --git a/Documentation/devicetree/bindings/clock/mediatek,mt8365-sys-clock.yaml b/Documentation/devicetree/bindings/clock/mediatek,mt8365-sys-clock.yaml
> new file mode 100644
> index 000000000000..4292a2fd1489
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/clock/mediatek,mt8365-sys-clock.yaml
> @@ -0,0 +1,47 @@
> +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: "http://devicetree.org/schemas/clock/mediatek,mt8365-sys-clock.yaml#";
> +$schema: "http://devicetree.org/meta-schemas/core.yaml#";

No quotes.

> +
> +title: MediaTek System Clock Controller for MT8365
> +
> +maintainers:
> +  - Fabien Parent <fparent@xxxxxxxxxxxx>

Ekh...

> +
> +description:
> +  The apmixedsys module provides most of PLLs which generated from SoC 26m.
> +  The topckgen provides dividers and muxes which provides the clock source to other IP blocks.
> +  The infracfg_ao and pericfg_ao provides clock gate in peripheral and infrastructure IP blocks.
> +
> +properties:
> +  compatible:
> +    items:
> +      - enum:
> +          - mediatek,mt8365-topckgen
> +          - mediatek,mt8365-infracfg
> +          - mediatek,mt8365-apmixedsys
> +          - mediatek,mt8365-pericfg
> +          - mediatek,mt8365-mcucfg
> +      - const: syscon
> +
> +  reg:
> +    maxItems: 1
> +
> +  '#clock-cells':
> +    const: 1
> +
> +required:
> +  - compatible
> +  - reg
> +  - '#clock-cells'
> +
> +additionalProperties: false
> +
> +examples:
> +  - |
> +    topckgen: clock-controller@10000000 {
> +        compatible = "mediatek,mt8365-topckgen", "syscon";
> +        reg = <0x10000000 0x1000>;
> +        #clock-cells = <1>;
> +    };
> diff --git a/include/dt-bindings/clock/mediatek,mt8365-clk.h b/include/dt-bindings/clock/mediatek,mt8365-clk.h
> new file mode 100644
> index 000000000000..aa8a0366caae
> --- /dev/null
> +++ b/include/dt-bindings/clock/mediatek,mt8365-clk.h
> @@ -0,0 +1,374 @@
> +/* SPDX-License-Identifier: GPL-2.0

Can you dual-license it?


> + *
> + * Copyright (c) 2022 MediaTek Inc.





Best regards,
Krzysztof