Re: [PATCH v1 1/2] PCI: dwc: drop dependency on ZONE_DMA32

[Christoph Hellwig]

On Tue, Aug 09, 2022 at 06:00:49PM +0000, Will McVicker wrote:
> Re-work the msi_msg DMA allocation logic to use dma_alloc_coherent()
> which uses the coherent DMA mask to try and return an allocation within
> the DMA mask limits. This allows kernel configurations that disable
> ZONE_DMA32 to continue supporting a 32-bit DMA mask. Without this patch,
> the PCIe host device will fail to probe when ZONE_DMA32 is disabled.

> +		dma_free_coherent(dev, PAGE_SIZE, pp->msi_page, pp->msi_data);

Isn't msi_page a struct page * which should become a void * now?

Otherwise this looks good and is what the driver should have done
from the very beginning.