Re: [PATCH] tools headers arm64: Fix compilation failure

[Suzuki K Poulose]

Hi Leo

On 11/08/2022 05:43, Leo Yan wrote:
> When build perf tool on x86_64, it reports failure for finding the
> header <asm/sysreg.h>:

Please could you mention the exact build options used for the perf
build ? (e.g, enable SPE)

>    In file included from util/arm-spe.c:37:
>    util/../../arch/arm64/include/asm/cputype.h:183:10: fatal error: asm/sysreg.h: No such file or directory
>      183 | #include <asm/sysreg.h>
>          |          ^~~~~~~~~~~~~~
>    compilation terminated.
>  > There have no sysreg.h in x86's asm folder, alternatively, this patch
> includes the sysreg.h header in the same folder with cputype.h to fix
> the compilation failure.

Wondering how the "cputype.h" was picked up from arch/arm64/include/ and
why not the sysreg.h ? Ideally, we would like to pickup the kernel
headers as it is without having to manually fixup, things like this.

> Fixes: 37402d5d061b ("tools headers arm64: Sync arm64's cputype.h with the kernel sources")

Also from the above commit,

"That addresses this perf build warning:

      Warning: Kernel ABI header at 
'tools/arch/arm64/include/asm/cputype.h' differs from latest version at 
'arch/arm64/include/asm/cputype.h'
      diff -u tools/arch/arm64/include/asm/cputype.h 
arch/arm64/include/asm/cputype.h
"

Wouldn't we re-introduce the warning back ?

Suzuki