Re: [PATCH v4] scsi: support packing multi-segment in UNMAP command

From: Bart Van Assche
Date: Thu Aug 11 2022 - 15:34:25 EST


On 6/16/22 19:01, Martin K. Petersen wrote:
As SCSI SBC4 specification section 5.30.2 describes that it can
support unmapping one or more LBA range in single UNMAP command.

However, previously we only pack one LBA range in UNMAP command by
default no matter device gives the block limits that says it can
support unmapping multiple LBA ranges with a single UNMAP command.

This patch sets max_discard_segments config according to block limits
of device, and supports unmapping multiple LBA ranges with a single
UNMAP command.

This looks OK to me. Will test with a variety of targets.

Hi Martin,

Have you already had the chance to test this patch? We would like to use this functionality in Android.

Thanks,

Bart.