Re: [PATCH v3 4/6] asus-wmi: Document previously added attributes

[Luke Jones]

Hi,

On Thu, 2022-08-11 at 17:08 +0200, Hans de Goede wrote:
> Hi,
> 
> On 8/9/22 11:25, Andy Shevchenko wrote:
> > On Tue, Aug 9, 2022 at 4:51 AM Luke D. Jones <luke@xxxxxxxxxx>
> > wrote:
> > > 
> > > Documents some previously added attributes:
> > > - dgpu_disable
> > > - egpu_enable
> > > - panel_od
> > 
> > Try to find a commit that introduced thouse and add the respective
> > Fixes tag.
> > 
> > ...
> > 
> > > -                       * keyboard - 0 or 1, unknown what effect
> > > this really has
> > > \ No newline at end of file
> > > +                       * keyboard - 0 or 1, unknown what effect
> > > this really has
> > 
> > Should be part of another patch.
> 
> Ack to both remarks.
> 
> Luke please make this patch one of the first patches in your next
> version / patch-series and then add the doucmentation of the new
> kbd RGB backlight attributes in the patches where you are also
> adding those actual attributes.

Yep, done. Everything is looking much cleaner too.