Re: [PATCH 4/4] dt-bindings: net: dsa: mediatek,mt7530: update json-schema

[Arınç ÜNAL]

On 2.08.2022 11:46, Krzysztof Kozlowski wrote:
> On 30/07/2022 16:26, Arınç ÜNAL wrote:
> > Update the json-schema for compatible devices.
> >
> > - Define acceptable phy-mode values for CPU port of each compatible device.
> > - Remove requiring the "reg" property since the referred dsa-port.yaml
> > already does that.
> > - Require mediatek,mcm for the described MT7621 SoCs as the compatible
> > string is only used for MT7530 which is a part of the multi-chip module.
>
> 3 separate patches.

Roger.

> > Signed-off-by: Arınç ÜNAL <arinc.unal@xxxxxxxxxx>
> > ---
> >   .../bindings/net/dsa/mediatek,mt7530.yaml     | 220 +++++++++++++++---
> >   1 file changed, 191 insertions(+), 29 deletions(-)
> >
> > diff --git a/Documentation/devicetree/bindings/net/dsa/mediatek,mt7530.yaml b/Documentation/devicetree/bindings/net/dsa/mediatek,mt7530.yaml
> > index a88e650e910b..a37a14fba9f6 100644
> > --- a/Documentation/devicetree/bindings/net/dsa/mediatek,mt7530.yaml
> > +++ b/Documentation/devicetree/bindings/net/dsa/mediatek,mt7530.yaml
> > @@ -135,35 +135,6 @@ properties:
> >         the ethsys.
> >       maxItems: 1
> >   
> > -patternProperties:
> > -  "^(ethernet-)?ports$":
> > -    type: object
>
> Actually four patches...
>
> I don't find this change explained in commit msg. What is more, it looks
> incorrect. All properties and patternProperties should be explained in
> top-level part.
>
> Defining such properties (with big piece of YAML) in each if:then: is no
> readable.

I can't figure out another way. I need to require certain properties for 
a compatible string AND certain enum/const for certain properties which 
are inside patternProperties for "^(ethernet-)?port@[0-9]+$" by reading 
the compatible string.

If I put allOf:if:then under patternProperties, I can't do the latter.

Other than readability to human eyes, binding check works as intended, 
in case there's no other way to do it.

Arınç