Re: [PATCH net-next v2] net: skb: prevent the split of kfree_skb_reason() by gcc

From: Miguel Ojeda
Date: Fri Aug 12 2022 - 04:51:15 EST


On Fri, Aug 12, 2022 at 4:50 AM <menglong8.dong@xxxxxxxxx> wrote:
>
> #define __noreturn __attribute__((__noreturn__))
>
> +#define __nofnsplit __attribute__((__optimize__("O1")))

This is still in the wrong place...

Also, from what the bot says, Clang does not support it. I took a
look, and that seems to be the case. ICC doesn't, either. Thus you
would need to guard it and also add the docs as needed, like the other
attributes.

(Not saying that solving the issue with the attribute is a good idea,
but if you really wanted to add one, it should be done properly)

Cheers,
Miguel