Re: [PATCH] block: Do not call blk_put_queue() if gendisk allocation fails
From: Jens Axboe
Date: Fri Aug 12 2022 - 08:42:18 EST
On Thu, 11 Aug 2022 20:23:37 -0300, Rafael Mendonca wrote:
> Commit 6f8191fdf41d ("block: simplify disk shutdown") removed the call
> to blk_get_queue() during gendisk allocation but missed to remove the
> corresponding cleanup code blk_put_queue() for it. Thus, if the gendisk
> allocation fails, the request_queue refcount gets decremented and
> reaches 0, causing blk_mq_release() to be called with a hctx still
> alive. That triggers a WARNING report, as found by syzkaller:
>
> [...]
Applied, thanks!
[1/1] block: Do not call blk_put_queue() if gendisk allocation fails
commit: aa0c680c3aa96a5f9f160d90dd95402ad578e2b0
Best regards,
--
Jens Axboe