Re: [PATCH v4 1/2] mm/gup.c: Don't pass gup_flags to check_and_migrate_movable_pages()

From: Matthew Wilcox
Date: Fri Aug 12 2022 - 14:12:13 EST


On Fri, Aug 12, 2022 at 11:02:42AM -0700, John Hubbard wrote:
> On 8/12/22 05:57, Matthew Wilcox wrote:
> > On Fri, Aug 12, 2022 at 12:13:08PM +1000, Alistair Popple wrote:
> > > + get_page(&folio->page);
> > > + unpin_user_page(&folio->page);
> >
> > https://lore.kernel.org/linux-mm/YvJddHPZsh7Lwzps@xxxxxxxxxxxxxxxxxxxx/
>
> The above fix shows up in patch 2/2. I noticed during review that
> it was applied to a different patch than the one you replied to,
> but figured it didn't matter which patch picked up this fix, since
> the problem precedes either patch.

Oh! I didn't realise patch 2/2 changed the same lines. let me go
and read 2/2.