Re: [PATCH] mfd: qcom-spmi-pmic: Add more PMIC SUBTYPE IDs
From: Caleb Connolly
Date: Sat Aug 13 2022 - 10:23:38 EST
On 13/08/2022 12:48, Luca Weiss wrote:
Add more IDs that are found in the downstream msm-4.19 kernel under the
path include/linux/qpnp/qpnp-revid.h.
Signed-off-by: Luca Weiss <luca.weiss@xxxxxxxxxxxxx>
---
I've noticed that some hex numbers in this list have uppercase letters,
some have lower case ones.
If wanted I can add a patch converting all to either upper- or lower
case. Anyone have a preference here?
I think(?) uppercase is the standard for Qualcomm stuff.
include/soc/qcom/qcom-spmi-pmic.h | 14 ++++++++++++++
1 file changed, 14 insertions(+)
diff --git a/include/soc/qcom/qcom-spmi-pmic.h b/include/soc/qcom/qcom-spmi-pmic.h
index 72398ff44719..bcb8e95d5dab 100644
--- a/include/soc/qcom/qcom-spmi-pmic.h
+++ b/include/soc/qcom/qcom-spmi-pmic.h
@@ -26,18 +26,32 @@
#define PM8901_SUBTYPE 0x0f
#define PM8950_SUBTYPE 0x10
#define PMI8950_SUBTYPE 0x11
+#define PMK8001_SUBTYPE 0x12
+#define PMI8996_SUBTYPE 0x13
#define PM8998_SUBTYPE 0x14
#define PMI8998_SUBTYPE 0x15
+#define SMB1381_SUBTYPE 0x17 > #define PM8005_SUBTYPE 0x18
#define PM660L_SUBTYPE 0x1A
#define PM660_SUBTYPE 0x1B
+#define SMB1355_SUBTYPE 0x1C
The SHIFT6mq uses this and schematics suggest it doesn't support SPMI. Does it
make sense to include these secondary charger chips here?
#define PM8150_SUBTYPE 0x1E
#define PM8150L_SUBTYPE 0x1f
#define PM8150B_SUBTYPE 0x20
#define PMK8002_SUBTYPE 0x21
+#define SMB1390_SUBTYPE 0x23
#define PM8009_SUBTYPE 0x24
+#define PMI632_SUBTYPE 0x25
#define PM8150C_SUBTYPE 0x26
+#define PM6150_SUBTYPE 0x28
#define SMB2351_SUBTYPE 0x29
+#define PM8008_SUBTYPE 0x2C
+#define PM6125_SUBTYPE 0x2D
+#define PM7250B_SUBTYPE 0x2E
+#define PMK8350_SUBTYPE 0x2F
+#define PMR735B_SUBTYPE 0x34
+#define PM6350_SUBTYPE 0x36
+#define PM2250_SUBTYPE 0x37
#define PMI8998_FAB_ID_SMIC 0x11
#define PMI8998_FAB_ID_GF 0x30
--
Kind Regards,
Caleb (they/he)