Re: [PATCH v5] Bluetooth: hci_sync: Remove redundant func definition

From: kernel test robot
Date: Sun Aug 14 2022 - 08:19:16 EST


Hi Zijun,

Thank you for the patch! Perhaps something to improve:

[auto build test WARNING on bluetooth/master]
[also build test WARNING on net-next/master net/master linus/master v5.19]
[cannot apply to bluetooth-next/master next-20220812]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url: https://github.com/intel-lab-lkp/linux/commits/Zijun-Hu/Bluetooth-hci_sync-Remove-redundant-func-definition/20220722-191804
base: https://git.kernel.org/pub/scm/linux/kernel/git/bluetooth/bluetooth.git master
config: x86_64-randconfig-a013 (https://download.01.org/0day-ci/archive/20220814/202208142029.Y9YOiT4V-lkp@xxxxxxxxx/config)
compiler: gcc-11 (Debian 11.3.0-3) 11.3.0
reproduce (this is a W=1 build):
# https://github.com/intel-lab-lkp/linux/commit/01ff3d2230c220a1387940ed594eccda09dc51fb
git remote add linux-review https://github.com/intel-lab-lkp/linux
git fetch --no-tags linux-review Zijun-Hu/Bluetooth-hci_sync-Remove-redundant-func-definition/20220722-191804
git checkout 01ff3d2230c220a1387940ed594eccda09dc51fb
# save the config file
mkdir build_dir && cp config build_dir/.config
make W=1 O=build_dir ARCH=x86_64 SHELL=/bin/bash net/bluetooth/

If you fix the issue, kindly add following tag where applicable
Reported-by: kernel test robot <lkp@xxxxxxxxx>

All warnings (new ones prefixed by >>):

>> net/bluetooth/hci_sync.c:2398:6: warning: no previous prototype for 'disconnected_accept_list_entries' [-Wmissing-prototypes]
2398 | bool disconnected_accept_list_entries(struct hci_dev *hdev)
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~


vim +/disconnected_accept_list_entries +2398 net/bluetooth/hci_sync.c

2397
> 2398 bool disconnected_accept_list_entries(struct hci_dev *hdev)
2399 {
2400 struct bdaddr_list *b;
2401
2402 list_for_each_entry(b, &hdev->accept_list, list) {
2403 struct hci_conn *conn;
2404
2405 conn = hci_conn_hash_lookup_ba(hdev, ACL_LINK, &b->bdaddr);
2406 if (!conn)
2407 return true;
2408
2409 if (conn->state != BT_CONNECTED && conn->state != BT_CONFIG)
2410 return true;
2411 }
2412
2413 return false;
2414 }
2415

--
0-DAY CI Kernel Test Service
https://01.org/lkp