Re: [f2fs-dev] [PATCH] f2fs: zoned device does not support ATGC

[Chao Yu]

On 2022/8/12 6:54, Jaegeuk Kim wrote:
> ATGC is using SSR which violates zoned device. >
> Signed-off-by: Jaegeuk Kim <jaegeuk@xxxxxxxxxx>
> ---
>   fs/f2fs/super.c | 4 ++++
>   1 file changed, 4 insertions(+)
>
> diff --git a/fs/f2fs/super.c b/fs/f2fs/super.c
> index 2451623c05a7..212ec2b4926b 100644
> --- a/fs/f2fs/super.c
> +++ b/fs/f2fs/super.c
> @@ -1298,6 +1298,10 @@ static int parse_options(struct super_block *sb, char *options, bool is_remount)
>   			F2FS_OPTION(sbi).discard_unit =
>   					DISCARD_UNIT_SECTION;
>   		}
> +		if (test_opt(sbi, ATGC)) {
> +			f2fs_err(sbi, "Zoned block device doesn't support ATGC.");
> +			return -EINVAL;
> +		}

ATGC is incompatible with LFS mode, we can check f2fs_lfs_mode() and ATGC
mountoption instead, as zoned device depends on LFS mode.

Thanks,

>   	}
>   
>   #ifdef CONFIG_F2FS_FS_COMPRESSION