Re: [PATCH v6] mm/page_owner.c: add llseek for page_owner

[Kassey Li]

On 8/11/2022 5:40 PM, Vlastimil Babka (SUSE) wrote:
> On 8/11/22 05:02, Kassey Li wrote:
> > hi, Vlastimil:
> >
> >
> > On 8/10/2022 5:02 PM, kernel test robot wrote:
> > > Hi Kassey,
> > >
> > > Thank you for the patch! Yet something to improve:
> > >
> > > [auto build test ERROR on v5.19]
> > > [also build test ERROR on next-20220810]
> > > [cannot apply to akpm-mm/mm-everything linus/master]
> > > [If your patch is applied to the wrong git tree, kindly drop us a note.
> > > And when submitting patch, we suggest to use '--base' as documented in
> > > https://git-scm.com/docs/git-format-patch#_base_tree_information]
> > >
> > > url:
> > > https://github.com/intel-lab-lkp/linux/commits/Kassey-Li/mm-page_owner-c-add-llseek-for-page_owner/20220810-093417
> > > base:    3d7cb6b04c3f3115719235cc6866b10326de34cd
> > > config: parisc-buildonly-randconfig-r004-20220810
> > > (https://download.01.org/0day-ci/archive/20220810/202208101628.o6qUzx50-lkp@xxxxxxxxx/config)
> > > compiler: hppa-linux-gcc (GCC) 12.1.0
> > > reproduce (this is a W=1 build):
> > >           wget
> > > https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross
> > > -O ~/bin/make.cross
> > >           chmod +x ~/bin/make.cross
> > >           #
> > > https://github.com/intel-lab-lkp/linux/commit/d2decd69a8d5756c1706092c805a4c8af14df471
> > >           git remote add linux-review https://github.com/intel-lab-lkp/linux
> > >           git fetch --no-tags linux-review
> > > Kassey-Li/mm-page_owner-c-add-llseek-for-page_owner/20220810-093417
> > >           git checkout d2decd69a8d5756c1706092c805a4c8af14df471
> > >           # save the config file
> > >           mkdir build_dir && cp config build_dir/.config
> > >           COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.1.0 make.cross
> > > W=1 O=build_dir ARCH=parisc SHELL=/bin/bash
> > >
> > > If you fix the issue, kindly add following tag where applicable
> > > Reported-by: kernel test robot <lkp@xxxxxxxxx>
> > >
> > > All errors (new ones prefixed by >>):
> > >
> > >      In file included from mm/page_owner.c:16:
> > > > > mm/../fs/proc/internal.h:51:9: error: unknown type name 'proc_write_t'
> > >         51 |         proc_write_t write;
> > >            |         ^~~~~~~~~~~~
> >
> > # CONFIG_PROC_FS is not set in some arch, so we can not directly include the
> > header file.
> > +#include "../fs/proc/internal.h"
> >
> > how about add an extern  ? or do you have other suggest  ?
>
> Hi, I replied to v5 after the bot reports:
>
> Sorry, my suggestion (to reuse mem_lseek() from proc) was wrong as the
> kernel test bot just showed us. mem_lseek() may be unavailable without
> CONFIG_PROC_FS.
> The easiest way is to add a page_owner specific lseek function back as in
> the early version, but make it correct for SEEK_CUR. Thanks.
   OK， got this point.
>