Re: [PATCH] net: fix potential refcount leak in ndisc_router_discovery()

From: patchwork-bot+netdevbpf
Date: Mon Aug 15 2022 - 06:50:22 EST


Hello:

This patch was applied to netdev/net.git (master)
by David S. Miller <davem@xxxxxxxxxxxxx>:

On Sat, 13 Aug 2022 20:49:08 +0800 you wrote:
> The issue happens on specific paths in the function. After both the
> object `rt` and `neigh` are grabbed successfully, when `lifetime` is
> nonzero but the metric needs change, the function just deletes the
> route and set `rt` to NULL. Then, it may try grabbing `rt` and `neigh`
> again if above conditions hold. The function simply overwrite `neigh`
> if succeeds or returns if fails, without decreasing the reference
> count of previous `neigh`. This may result in memory leaks.
>
> [...]

Here is the summary with links:
- net: fix potential refcount leak in ndisc_router_discovery()
https://git.kernel.org/netdev/net/c/7396ba87f1ed

You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html