Re: [RFC PATCH] Soundwire: Initialize multi_link with fwnode props

[Khalid Masum]

On 8/15/22 14:16, Pierre-Louis Bossart wrote:
> On 8/15/22 06:28, Khalid Masum wrote:
> > On 8/15/22 00:46, Andy Shevchenko wrote:
> > > On Sun, Aug 14, 2022 at 11:31 AM Khalid Masum
> > > <khalid.masum.92@xxxxxxxxx> wrote:
> > > > According to the TODO, In sw_bus_master_add, bus->multi_link is to be
> > > > populated with properties from FW node props. Make this happen by
> > > > creating a new fwnode_handle flag FWNODE_FLAG_MULTI_LINKED and use
> > > > the flag to store the multi_link value from intel_link_startup. Use
> > > > this flag to initialize bus->multi_link.
> > >
> > > ...
> > >
> > > >           /*
> > > >            * Initialize multi_link flag
> > > > -        * TODO: populate this flag by reading property from FW node
> > > >            */
> > > > -       bus->multi_link = false;
> > > > +       bus->multi_link = (fwnode->flags & FWNODE_FLAG_MULTI_LINKED)
> > > > +               == FWNODE_FLAG_MULTI_LINKED;
> > >
> > > NAK (as far as I understood the context of the comment and the change
> > > itself).
> > >
> > > These flags are for devlink, we do not mix FW properties with those
> > > internal flags anyhow. The comment suggests that this should be az
> > > property. Also commit message doesn't explain the relation to devlink.
> > That is a good information to know. Thanks.
> >
> > I shall try to find out if I can somehow get multi_link's value from
> > fwnode in any other way and look into devlink in the process.
> >
> > If you have any suggestions regarding this TODO, please let me know.
>
> The suggestion is to remove the TODO and leave the code as is: the
> capabilities enabled for multi-link are required as part of the
> programming sequences, even when a stream uses a single link we still
> use the syncArm/syncGo sequences.
>
> Please don't change this.

Thanks for the suggestion! I shall send a patch with the TODO removed, 
leaving the code as is.

  -- Khalid Masum