Re: [PATCH 0/6] asus-wmi: cleanup dgpu_disable, egpu_enable, panel_od

From: Hans de Goede
Date: Mon Aug 15 2022 - 11:02:57 EST


Hi,

On 8/13/22 00:25, Luke D. Jones wrote:
> This patch series does two things for previously added features:
> - dgpu_disable
> - egpu_enable
> - panel_od
>
> The fixes add missing documentation, and the refactors vastly clean up how
> the features work, including reading the values from WMI methods on *_show()
> and checking the result correctly (these methods return 1 on success).

Thank you for your patch-series, I've applied the series to my
review-hans branch:
https://git.kernel.org/pub/scm/linux/kernel/git/pdx86/platform-drivers-x86.git/log/?h=review-hans

Note it will show up in my review-hans branch once I've pushed my
local branch there, which might take a while.

Once I've run some tests on this branch the patches there will be
added to the platform-drivers-x86/for-next branch and eventually
will be included in the pdx86 pull-request to Linus for the next
merge-window.

Regards,

Hans


>
> Luke D. Jones (6):
> Fixes 98829e84dc67 ("asus-wmi: Add dgpu disable method")
> Fixes: 382b91db8044 ("asus-wmi: Add egpu enable method")
> Fixes: ca91ea34778f ("asus-wmi: Add panel overdrive functionality")
> asus-wmi: Refactor disable_gpu attribute
> asus-wmi: Refactor egpu_enable attribute
> asus-wmi: Refactor panel_od attribute
>
> .../ABI/testing/sysfs-platform-asus-wmi | 28 +++
> drivers/platform/x86/asus-wmi.c | 231 ++++++------------
> 2 files changed, 103 insertions(+), 156 deletions(-)
>