Re: [PATCH v3 3/4] dt-bindings: sram: sunxi-sram: Add optional regulators child
From: Heiko Stübner
Date: Mon Aug 15 2022 - 13:03:05 EST
Am Montag, 15. August 2022, 16:01:47 CEST schrieb Rob Herring:
> On Sun, 14 Aug 2022 23:34:34 -0500, Samuel Holland wrote:
> > Some sunxi SoCs have in-package regulators controlled by a register in
> > the system control MMIO block. Allow a child node for these regulators
> > in addition to SRAM child nodes.
> >
> > Signed-off-by: Samuel Holland <samuel@xxxxxxxxxxxx>
> > ---
> >
> > Changes in v3:
> > - Require the regulators node to have a unit address
> > - Reference the regulator schema from the SRAM controller schema
> > - Move the system LDOs example to the SRAM controller schema
> > - Reorder the patches so the example passes validation
> >
> > Changes in v2:
> > - New patch for v2
> >
> > .../allwinner,sun4i-a10-system-control.yaml | 29 +++++++++++++++++++
> > 1 file changed, 29 insertions(+)
> >
>
> My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check'
> on your patch (DT_CHECKER_FLAGS is new in v5.13):
>
> yamllint warnings/errors:
>
> dtschema/dtc warnings/errors:
> Documentation/devicetree/bindings/sram/allwinner,sun4i-a10-system-control.example.dtb:0:0: /example-1/syscon@3000000: failed to match any schema with compatible: ['allwinner,sun20i-d1-system-control']
This got added in
"dt-bindings: sram: sunxi-sram: Add D1 compatible string"
( https://lore.kernel.org/r/20220815041248.53268-3-samuel@xxxxxxxxxxxx )
>
> doc reference errors (make refcheckdocs):
>
> See https://patchwork.ozlabs.org/patch/
>
> This check can fail if there are any dependencies. The base for a patch
> series is generally the most recent rc1.
>
> If you already ran 'make dt_binding_check' and didn't see the above
> error(s), then make sure 'yamllint' is installed and dt-schema is up to
> date:
>
> pip3 install dtschema --upgrade
>
> Please check and re-submit.
>
>
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel@xxxxxxxxxxxxxxxxxxx
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
>