Re: [PATCH v2 09/10] sched/psi: per-cgroup PSI stats disable/re-enable interface
From: Tejun Heo
Date: Mon Aug 15 2022 - 18:42:27 EST
Hello,
On Mon, Aug 15, 2022 at 11:49:55AM -0400, Johannes Weiner wrote:
> I think it should also add/remove the pressure files when enabling and
> disabling the aggregation, since their contents would be stale and
> misleading.
>
> Take a look at cgroup_add_dfl_cftypes() and cgroup_rm_cftypes()
The problem with adding cftypes dynamically is that it can fail, which isn't
the end of the world here but still kinda sucks. I think what we actually
wanna do is hiding and unhiding while keeping all the data structures in
place which is needed somewhere else anyway.
Thanks.
--
tejun