Re: [PATCH net-next,0/3] cleanup of qdisc offload function
From: shaozhengchao
Date: Tue Aug 16 2022 - 03:09:04 EST
On 2022/8/16 11:10, Jakub Kicinski wrote:
On Tue, 16 Aug 2022 10:04:20 +0800 Zhengchao Shao wrote:
Some qdiscs don't care return value of qdisc offload function, so make
function void.
How many of these patches do you have? Is there a goal you're working
towards? I don't think the pure return value removals are worth the
noise. They don't even save LoC:
3 files changed, 9 insertions(+), 9 deletions(-)
Hi Jakub.
Thank you for your reply. Recently I've been studying the kernel code
related to qdisc, and my goal is to understand how qdisc works. If the
code can be optimized, I do what I can to modify the optimization. Is it
more appropriate to add warning to the offload return value? I look
forward to your reply. Thank you.
Zhengchao Shao