Re: [PATCH v2 net-next] net: ethernet: ti: davinci_mdio: Add workaround for errata i2329

[Ravi Gunasekaran]

On 12/08/22 9:24 pm, Andrew Lunn wrote:
> > sh_eth is not configured for autosuspend and uses only pm_runtime_put().
>
> I don't know the runtime power management code very well. We should
> probably ask somebody how does. However:
>
> https://elixir.bootlin.com/linux/latest/source/drivers/base/power/runtime.c#L168
>
> This suggests it should be safe to perform an auto suspend on a device
> which is not configured for auto suspend. To me, it looks like is
> should directly suspend.

I checked the pm_runtime_put() and pm_runtime_put_autosuspend() and I 
have quite a few unanswered questions. I do not have much knowledge 
about the runtime PM, so I'm not confident about adding the runtime PM 
mdiobb_read/mdiobb_write variants in the mdio bitbang core. I would 
rather take a safe approach for now and stick with the implementation 
submitted in this v2 patch.

Thanks for your feedback on this submission so far. I will fix the two 
other comments and send out a v3 patch.

--
Regards,
Ravi