Re: [PATCH v3 7/8] arm64: dts: imx8mm-kontron: Add SPI NOR partition layout

[Krzysztof Kozlowski]

On 15/08/2022 14:01, Frieder Schrempf wrote:
> From: Frieder Schrempf <frieder.schrempf@xxxxxxxxxx>
> 
> This is the layout used by the bootloader. Add it to the kernel
> devicetree to make the same layout available in Linux and have
> the devicetrees synced.
> 
> Signed-off-by: Frieder Schrempf <frieder.schrempf@xxxxxxxxxx>
> ---
> Changes in v3:
> * rebase on v6.0-rc1
> 
> Changes in v2:
> * new patch
> ---
>  .../boot/dts/freescale/imx8mm-kontron-sl.dtsi | 21 +++++++++++++++++++
>  1 file changed, 21 insertions(+)
> 
> diff --git a/arch/arm64/boot/dts/freescale/imx8mm-kontron-sl.dtsi b/arch/arm64/boot/dts/freescale/imx8mm-kontron-sl.dtsi
> index ce9c27619e26..c227ca813d9e 100644
> --- a/arch/arm64/boot/dts/freescale/imx8mm-kontron-sl.dtsi
> +++ b/arch/arm64/boot/dts/freescale/imx8mm-kontron-sl.dtsi
> @@ -66,6 +66,27 @@ flash@0 {
>  		compatible = "mxicy,mx25r1635f", "jedec,spi-nor";
>  		spi-max-frequency = <80000000>;
>  		reg = <0>;
> +
> +		partitions {
> +			compatible = "fixed-partitions";
> +			#address-cells = <1>;
> +			#size-cells = <1>;
> +
> +			partition@0 {
> +				label = "u-boot";
> +				reg = <0x0 0x1E0000>;

lowercase hex everywhere

> +			};
> +
> +			partition@1 {
> +				label = "env";
> +				reg = <0x1E0000 0x10000>;

Your reg does not match unit address. It should cause dtc warnings.

Best regards,
Krzysztof