Re: [PATCH V2 1/8] perf/x86/intel/P4: Fix smp_num_siblings usage
From: Peter Zijlstra
Date: Tue Aug 16 2022 - 06:47:52 EST
On Tue, Aug 16, 2022 at 05:47:14PM +0800, Zhang Rui wrote:
> On Tue, 2022-08-16 at 10:27 +0200, Peter Zijlstra wrote:
> > On Tue, Aug 16, 2022 at 01:16:26PM +0800, Zhang Rui wrote:
> > > smp_num_siblings can be larger than 2.
> > >
> > > Any value larger than 1 suggests HT is supported.
> >
> > Subject and Changelog are still utterly insane.
>
> what about this one, do I need to resend the full series?
>
> thanks,
> rui
>
> From 2e368e6afa83cb73e44ac8c3cf8339207097d9e1 Mon Sep 17 00:00:00 2001
> From: Zhang Rui <rui.zhang@xxxxxxxxx>
> Date: Tue, 28 Jun 2022 11:02:12 +0800
> Subject: [PATCH V3 1/8] perf/x86/intel/P4: unify logic for detecting HT
>
> Any value larger than 1 suggests HT is supported.
>
> Although smp_num_siblings cannot be larger than 2 on P4 platform, it is
> better to keep this logic consistent across the kernel.
>
> Reviewed-by: Len Brown <len.brown@xxxxxxxxx>
> Signed-off-by: Zhang Rui <rui.zhang@xxxxxxxxx>
Yes that works for me; thanks!