Re: [PATCH] dt-bindings: pinctrl: mt8186: Fix 'reg-names' for pinctrl nodes

From: Allen-KH Cheng
Date: Tue Aug 16 2022 - 08:56:41 EST


Hi Krzysztof,

On Tue, 2022-08-16 at 10:14 +0300, Krzysztof Kozlowski wrote:
> On 15/08/2022 15:25, Allen-KH Cheng wrote:
> > There are 8 GPIO physical address bases in mt8186, corresponding to
> > the
> > items of 'reg-names' with the pinctrl driver. but the order of
>
> New sentences start with capital letter.
>
> > 'reg-names' is not correct. The mt8186 pinctrl driver would get the
> > wrong address, causing the system to restart when regulator
> > initializes
> > . we
>
> ^^^ Something is missing. Sentence looks unfinished, full stop is in
> new
> line, next sentence does not start with capital letter.
>
>

Thanks for your kind reminder.
I'll update in the next version.

Best regards,
Allen

> > fix 'reg-names' for pinctrl nodes and the pinctrl-mt8186 example
> > in bindings.
> >
> > Fixes: 338e953f1bd1 ("dt-bindings: pinctrl: mt8186: add pinctrl
> > file and binding document")
> > Signed-off-by: Allen-KH Cheng <allen-kh.cheng@xxxxxxxxxxxx>
> > Signed-off-by: Guodong Liu <guodong.liu@xxxxxxxxxxxx>
> > ---
>
> Best regards,
> Krzysztof