Re: [PATCH 5.19 0784/1157] scsi: sd: Rework asynchronous resume support

[Bart Van Assche]

On 8/15/22 11:02, Greg Kroah-Hartman wrote:
> From: Bart Van Assche <bvanassche@xxxxxxx>
>
> [ Upstream commit 88f1669019bd62b3009a3cebf772fbaaa21b9f38 ]
>
> For some technologies, e.g. an ATA bus, resuming can take multiple
> seconds. Waiting for resume to finish can cause a very noticeable delay.
> Hence this commit that restores the behavior from before "scsi: core: pm:
> Rely on the device driver core for async power management" for most SCSI
> devices.
>
> This commit introduces a behavior change: if the START command fails, do
> not consider this as a SCSI disk resume failure.
>
> Link: https://bugzilla.kernel.org/show_bug.cgi?id=215880
> Link: https://lore.kernel.org/r/20220630195703.10155-3-bvanassche@xxxxxxx
> Fixes: a19a93e4c6a9 ("scsi: core: pm: Rely on the device driver core for async power management")

Hi Greg,

It has been reported that this patch causes a regression, namely disks 
not coming back after a resume. That issue is worse than the issue fixed 
by this patch - eliminating a delay. Please drop this patch from the 
stable tree.

A revert of this patch has been posted on the linux-scsi mailing list. 
See also 
https://lore.kernel.org/linux-scsi/8a83665a-1951-a326-f930-8fcbb0c4dd9a@xxxxxxxxxx/.

Thanks,

Bart.