RE: [EXTERNAL] Re: [PATCH v1 1/1] sound: Add a new kcontrol

[Lu, Kevin]

Hi Mark,

Thanks for your patience to point out my mistakes, It will be helpful for the future patch submitting.
I will take every code change carefully.

Best regards
Kevin

-----Original Message-----
From: Mark Brown <broonie@xxxxxxxxxx> 
Sent: Wednesday, August 17, 2022 1:49 AM
To: Kevin Lu <luminlong@xxxxxxx>
Cc: linux-kernel@xxxxxxxxxxxxxxx; Ding, Shenghao <shenghao-ding@xxxxxx>; Lu, Kevin <kevin-lu@xxxxxx>
Subject: [EXTERNAL] Re: [PATCH v1 1/1] sound: Add a new kcontrol

On Mon, Aug 15, 2022 at 07:27:15PM +0800, Kevin Lu wrote:
> Add a new kcontrol for phase calib

This looks mostly good now - one small issue below which I'll fix up myself and apply.

Please submit patches using subject lines reflecting the style for the subsystem, this makes it easier for people to identify relevant patches.
Look at what existing commits in the area you're changing are doing and make sure your subject lines visually resemble what they're doing.
There's no need to resubmit to fix this alone.

> +	ADCX140_PHASE_CALIB_SWITCH("Adcx140 Phase Calib Switch"),

We wouldn't normally put the CODEC name in the control name, it's not really relevant to users and if some disambiguation is needed it's usually better to do it in a board specific way (eg, describing the output the CODEC is connected to) using the support ASoC has for adding prefixes.  Better would be "Phase Callibration Switch".