Re: [PATCH v8 1/2] drivers/coresight: Add UltraSoc System Memory Buffer driver

[hejunhao]

On 2022/8/17 2:00, Randy Dunlap wrote:

Hi Randy,

Thanks for your comments.

> Hi--
>
> On 8/16/22 06:16, Junhao He wrote:
> > diff --git a/drivers/hwtracing/coresight/Kconfig b/drivers/hwtracing/coresight/Kconfig
> > index 514a9b8086e3..4380eb1a0a73 100644
> > --- a/drivers/hwtracing/coresight/Kconfig
> > +++ b/drivers/hwtracing/coresight/Kconfig
> > @@ -201,4 +201,14 @@ config CORESIGHT_TRBE
> >   
> >   	  To compile this driver as a module, choose M here: the module will be
> >   	  called coresight-trbe.
> Please insert a blank line here like it is done elsewhere.

I will fix it in the next version.
Thanks.

> > +config ULTRASOC_SMB
> > +	tristate "Ultrasoc system memory buffer drivers"
> > +	depends on ACPI && ARM64 && CORESIGHT_LINKS_AND_SINKS
> > +	help
> > +	  This driver provides support for the Ultrasoc system memory buffer (SMB).
> > +	  SMB is responsible for receiving the trace data from Coresight ETM devices
> > +	  and storing them to a system buffer.
> > +
> > +	  To compile this driver as a module, choose M here: the module will be
> > +	  called ultrasoc-smb.
> >   endif
> thanks.

Regards,
Junhao.