Re: [PATCH 2/6] mm/hugetlb: fix WARN_ON(!kobj) in sysfs_create_group()

From: Muchun Song
Date: Tue Aug 16 2022 - 22:31:50 EST




> On Aug 16, 2022, at 21:05, Miaohe Lin <linmiaohe@xxxxxxxxxx> wrote:
>
> If sysfs_create_group() fails with hstate_attr_group, hstate_kobjs[hi]
> will be set to NULL. Then it will be passed to sysfs_create_group() if
> h->demote_order != 0 thus triggering WARN_ON(!kobj) check. Fix this by
> making sure hstate_kobjs[hi] != NULL when calling sysfs_create_group.
>
> Signed-off-by: Miaohe Lin <linmiaohe@xxxxxxxxxx>

It’s better to add a Fixes tag here.

Reviewed-by: Muchun Song <songmuchun@xxxxxxxxxxxxx>

Thanks.