Re: [PATCH 2/3] iommu/dma: Move public interfaces to linux/iommu.h
From: Marc Zyngier
Date: Wed Aug 17 2022 - 08:19:22 EST
On Tue, 16 Aug 2022 18:28:04 +0100,
Robin Murphy <robin.murphy@xxxxxxx> wrote:
>
> The iommu-dma layer is now mostly encapsulated by iommu_dma_ops, with
> only a couple more public interfaces left pertaining to MSI integration.
> Since these depend on the main IOMMU API header anyway, move their
> declarations there, taking the opportunity to update the half-baked
> comments to proper kerneldoc along the way.
>
> Signed-off-by: Robin Murphy <robin.murphy@xxxxxxx>
> ---
>
> Note that iommu_setup_dma_ops() should also become internal in a future
> phase of the great IOMMU API upheaval - for now as the last bit of true
> arch code glue I consider it more "necessarily exposed" than "public".
>
> arch/arm64/mm/dma-mapping.c | 2 +-
> drivers/iommu/dma-iommu.c | 15 ++++++++++--
> drivers/irqchip/irq-gic-v2m.c | 2 +-
> drivers/irqchip/irq-gic-v3-its.c | 2 +-
> drivers/irqchip/irq-gic-v3-mbi.c | 2 +-
> drivers/irqchip/irq-ls-scfg-msi.c | 2 +-
> drivers/vfio/vfio_iommu_type1.c | 1 -
> include/linux/dma-iommu.h | 40 -------------------------------
> include/linux/iommu.h | 36 ++++++++++++++++++++++++++++
> 9 files changed, 54 insertions(+), 48 deletions(-)
For the irqchip side:
Acked-by: Marc Zyngier <maz@xxxxxxxxxx>
M.
--
Without deviation from the norm, progress is not possible.