Re: [PATCH] nvmem: brcm_nvram: Use kzalloc for allocating only one element

[Srinivas Kandagatla]

On 10/08/2022 04:10, Kenneth Lee wrote:
> Use kzalloc(...) rather than kcalloc(1, ...) because the number of
> elements we are specifying in this case is 1, so kzalloc would
> accomplish the same thing and we can simplify.
>
> Signed-off-by: Kenneth Lee <klee33@xxxxxx>
> ---

Applied thanks,

--srini
>   drivers/nvmem/brcm_nvram.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/nvmem/brcm_nvram.c b/drivers/nvmem/brcm_nvram.c
> index 450b927691c3..4441daa20965 100644
> --- a/drivers/nvmem/brcm_nvram.c
> +++ b/drivers/nvmem/brcm_nvram.c
> @@ -96,7 +96,7 @@ static int brcm_nvram_parse(struct brcm_nvram *priv)
>   
>   	len = le32_to_cpu(header.len);
>   
> -	data = kcalloc(1, len, GFP_KERNEL);
> +	data = kzalloc(len, GFP_KERNEL);
>   	memcpy_fromio(data, priv->base, len);
>   	data[len - 1] = '\0';
>