Re: [PATCH v4] Revert "mlxsw: core: Add the hottest thermal zone detection"
From: Ido Schimmel
Date: Wed Aug 17 2022 - 12:12:08 EST
On Wed, Aug 17, 2022 at 05:30:40PM +0200, Daniel Lezcano wrote:
> This reverts commit 2dc2f760052da4925482ecdcdc5c94d4a599153c and
> commit 6f73862fabd93213de157d9cc6ef76084311c628.
>
> As discussed in the thread:
>
> https://lore.kernel.org/all/f3c62ebe-7d59-c537-a010-bff366c8aeba@xxxxxxxxxx/
>
> the feature provided by commits 2dc2f760052da and 6f73862fabd93 is
> actually already handled by the thermal framework via the cooling
> device state aggregation, thus all this code is pointless.
>
> The revert conflicts with the following changes:
> - 7f4957be0d5b8: thermal: Use mode helpers in drivers
> - 6a79507cfe94c: mlxsw: core: Extend thermal module with per QSFP module thermal zones
>
> These conflicts were fixed and the resulting changes are in this patch.
>
> Both reverts are in the same change as requested by Ido Schimmel:
>
> https://lore.kernel.org/all/Yvz7+RUsmVco3Xpj@shredder/
>
> Signed-off-by: Daniel Lezcano <daniel.lezcano@xxxxxxxxxx>
> Tested-by: Vadim Pasternak <vadimp@xxxxxxxxxx>
Reviewed-by: Ido Schimmel <idosch@xxxxxxxxxx>
Jakub, Daniel wants to route this patch via his tree. Do you mind?
I spoke with Vadim earlier this week and we do not expect changes to
this file during the current cycle.
Thanks