Re: [PATCH] net: Fix suspicious RCU usage in bpf_sk_reuseport_detach()

From: David Howells
Date: Wed Aug 17 2022 - 16:56:06 EST


Jakub Kicinski <kuba@xxxxxxxxxx> wrote:

> I like your version because it documents what the lock protecting this
> field is.
>
> In fact should we also add && sock_owned_by_user(). Martin, WDYT? Would
> that work for reuseport? Jakub S is fixing l2tp to hold the socket lock
> while setting this field, yet most places take the callback lock...

So how do you want to proceed? My first version of the patch with
sock_owned_by_user()?

David