[intel-tdx:guest-filter 5/28] arch/x86/coco/tdx/filter.c:25:22: sparse: sparse: symbol 'pci_allow_ids' was not declared. Should it be static?
From: kernel test robot
Date: Wed Aug 17 2022 - 22:01:06 EST
tree: https://github.com/intel/tdx.git guest-filter
head: b5812625f245fbcee0c97d9a431d0f7f2f0aea6d
commit: 7f8f03269925a391cebded5a705121352e5b0e1d [5/28] x86/tdx: Add device filter support for x86 TDX guest platform
config: x86_64-randconfig-s022 (https://download.01.org/0day-ci/archive/20220818/202208180949.U99TQppy-lkp@xxxxxxxxx/config)
compiler: gcc-11 (Debian 11.3.0-5) 11.3.0
reproduce:
# apt-get install sparse
# sparse version: v0.6.4-39-gce1a6720-dirty
# https://github.com/intel/tdx/commit/7f8f03269925a391cebded5a705121352e5b0e1d
git remote add intel-tdx https://github.com/intel/tdx.git
git fetch --no-tags intel-tdx guest-filter
git checkout 7f8f03269925a391cebded5a705121352e5b0e1d
# save the config file
mkdir build_dir && cp config build_dir/.config
make W=1 C=1 CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__' O=build_dir ARCH=x86_64 SHELL=/bin/bash arch/x86/coco/tdx/
If you fix the issue, kindly add following tag where applicable
Reported-by: kernel test robot <lkp@xxxxxxxxx>
sparse warnings: (new ones prefixed by >>)
>> arch/x86/coco/tdx/filter.c:25:22: sparse: sparse: symbol 'pci_allow_ids' was not declared. Should it be static?
vim +/pci_allow_ids +25 arch/x86/coco/tdx/filter.c
16
17 /*
18 * Allow list for PCI bus
19 *
20 * NOTE: Device ID is duplicated here. But for small list
21 * of devices, it is easier to maintain the duplicated list
22 * here verses exporting the device ID table from the driver
23 * and use it.
24 */
> 25 struct pci_device_id pci_allow_ids[] = {
26 { PCI_DEVICE(PCI_VENDOR_ID_REDHAT_QUMRANET, VIRTIO_TRANS_ID_NET) },
27 { PCI_DEVICE(PCI_VENDOR_ID_REDHAT_QUMRANET, VIRTIO_TRANS_ID_BLOCK) },
28 { PCI_DEVICE(PCI_VENDOR_ID_REDHAT_QUMRANET, VIRTIO_TRANS_ID_CONSOLE) },
29 { PCI_DEVICE(PCI_VENDOR_ID_REDHAT_QUMRANET, VIRTIO_TRANS_ID_9P) },
30 { PCI_DEVICE(PCI_VENDOR_ID_REDHAT_QUMRANET, VIRTIO1_ID_NET) },
31 { PCI_DEVICE(PCI_VENDOR_ID_REDHAT_QUMRANET, VIRTIO1_ID_BLOCK) },
32 { PCI_DEVICE(PCI_VENDOR_ID_REDHAT_QUMRANET, VIRTIO1_ID_CONSOLE) },
33 { PCI_DEVICE(PCI_VENDOR_ID_REDHAT_QUMRANET, VIRTIO1_ID_9P) },
34 { 0, },
35 };
36
--
0-DAY CI Kernel Test Service
https://01.org/lkp