Re: [PATCH 1/4] media: dt-bindings: media: Document RZ/G2L CSI-2 block

From: Geert Uytterhoeven
Date: Thu Aug 18 2022 - 05:03:12 EST


Hi Prabhakar,

On Mon, Aug 1, 2022 at 11:47 PM Lad Prabhakar
<prabhakar.mahadev-lad.rj@xxxxxxxxxxxxxx> wrote:
> Document the CSI-2 block which is part of CRU found in Renesas
> RZ/G2L SoC.
>
> Signed-off-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@xxxxxxxxxxxxxx>
> ---
> RFC v2 -> v1
> * Fixed review comments pointed by Rob and Jacopo.

Thanks for the update!

> --- /dev/null
> +++ b/Documentation/devicetree/bindings/media/renesas,rzg2l-csi2.yaml
> @@ -0,0 +1,149 @@

> + resets:
> + items:
> + - description: CRU_CMN_RSTB reset terminal
> +
> + reset-names:
> + const: cmn-rstb

While it doesn't hurt to always have reset-names, you may want to drop
it, as there is only a single reset.

Gr{oetje,eeting}s,

Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds