Re: [PATCH v5 22/22] Documentation/x86: Add documentation for TDX host support

[Huang, Kai]

On Thu, 2022-08-18 at 11:07 +0700, Bagas Sanjaya wrote:
> On Wed, Jun 22, 2022 at 11:17:50PM +1200, Kai Huang wrote:
> > +Kernel detects TDX and the TDX private KeyIDs during kernel boot.  User
> > +can see below dmesg if TDX is enabled by BIOS:
> > +
> > +|  [..] tdx: SEAMRR enabled.
> > +|  [..] tdx: TDX private KeyID range: [16, 64).
> > +|  [..] tdx: TDX enabled by BIOS.
> > +
> <snipped>
> > +Initializing the TDX module consumes roughly ~1/256th system RAM size to
> > +use it as 'metadata' for the TDX memory.  It also takes additional CPU
> > +time to initialize those metadata along with the TDX module itself.  Both
> > +are not trivial.  Current kernel doesn't choose to always initialize the
> > +TDX module during kernel boot, but provides a function tdx_init() to
> > +allow the caller to initialize TDX when it truly wants to use TDX:
> > +
> > +        ret = tdx_init();
> > +        if (ret)
> > +                goto no_tdx;
> > +        // TDX is ready to use
> > +
> 
> Hi,
> 
> The code block above produces Sphinx warnings:
> 
> Documentation/x86/tdx.rst:69: WARNING: Unexpected indentation.
> Documentation/x86/tdx.rst:70: WARNING: Block quote ends without a blank line; unexpected unindent.
> 
> I have applied the fixup:
> 

Thank you! will fix in next version.


-- 
Thanks,
-Kai