Re: [PATCH 05/16] powerpc: Skip objtool from running on drivers/crypto/vmx/aesp8-ppc.o

[Sathvika Vasireddy]

On 10/08/22 14:04, Christophe Leroy wrote:
> Le 08/08/2022 à 13:48, Sathvika Vasireddy a écrit :
> > With objtool enabled, below warnings are seen when trying to build:
> >
> > drivers/crypto/vmx/aesp8-ppc.o: warning: objtool: aes_p8_set_encrypt_key+0x44: unannotated intra-function call
> >
> > drivers/crypto/vmx/aesp8-ppc.o: warning: objtool: .text+0x2448: unannotated intra-function call
> >
> > drivers/crypto/vmx/aesp8-ppc.o: warning: objtool: .text+0x2d68: unannotated intra-function call
> >
> > Skip objtool from running on this file, as
> > there are no calls to _mcount.
> Why not fix it the same way as for other files ? Please explain.
For two main reasons:

1. Since this file comes from OpenSSL, and since it is a perl file which 
generates a .S file,  it may not
    be the best choice to make too many code changes to such files, 
unless absolutely necessary.

2. Second reason is that, at least as far as the objtool --mcount 
functionality is concerned, we do not
    have to run objtool on that file because that file does not have 
any calls to _mcount.
> > Signed-off-by: Sathvika Vasireddy <sv@xxxxxxxxxxxxx>
> > ---
> >    drivers/crypto/vmx/Makefile | 2 ++
> >    1 file changed, 2 insertions(+)
> >
> > diff --git a/drivers/crypto/vmx/Makefile b/drivers/crypto/vmx/Makefile
> > index 2560cfea1dec..7b41f0da6807 100644
> > --- a/drivers/crypto/vmx/Makefile
> > +++ b/drivers/crypto/vmx/Makefile
> > @@ -9,3 +9,5 @@ targets += aesp8-ppc.S ghashp8-ppc.S
> >    
> >    $(obj)/aesp8-ppc.S $(obj)/ghashp8-ppc.S: $(obj)/%.S: $(src)/%.pl FORCE
> >    	$(call if_changed,perl)
> > +
> > +OBJECT_FILES_NON_STANDARD_aesp8-ppc.o := y