Re: [PATCH v1 6/6] perf build: Enable -Wthread-safety with clang
From: Ian Rogers
Date: Thu Aug 18 2022 - 12:24:25 EST
On Thu, Aug 18, 2022 at 8:59 AM Namhyung Kim <namhyung@xxxxxxxxxx> wrote:
>
> On Thu, Aug 18, 2022 at 6:17 AM Ian Rogers <irogers@xxxxxxxxxx> wrote:
> >
> > On Wed, Aug 17, 2022, 11:11 PM Namhyung Kim <namhyung@xxxxxxxxxx> wrote:
> > >
> > > Hi Ian,
> > >
> > > On Tue, Aug 16, 2022 at 10:39 PM Ian Rogers <irogers@xxxxxxxxxx> wrote:
> > > >
> > > > If building with clang then enable -Wthread-safety warnings.
> > >
> > > Do you know the minimal supported version for the option?
> > > I'm not sure we have a check for that kind of thing.
> >
> >
> > It has been supported for a long time, close to 10 years. Looking
> > around it looks like clang 3.5 had the support. For context, BPF was
> > supported after clang 3.7. Given this long support, and we don't
> > version check for BPF, I think it is okay to assume the flag is
> > supported.
>
> Good, thanks for checking it.
It was a good point, thanks for the reminder!
Ian