Re: [PATCH v9 02/27] kallsyms: avoid hardcoding buffer size

[Geert Stappers]

On Wed, Aug 17, 2022 at 12:37:40PM -0700, Kees Cook wrote:
> On Fri, Aug 05, 2022 at 05:41:47PM +0200, Miguel Ojeda wrote:
> > From: Boqun Feng <boqun.feng@xxxxxxxxx>
> > 
> > This introduces `KSYM_NAME_LEN_BUFFER` in place of the previously
> > hardcoded size of the input buffer.
> > 
> > It will also make it easier to update the size in a single place
> > in a later patch.
> > 
> > Signed-off-by: Boqun Feng <boqun.feng@xxxxxxxxx>
> > Co-developed-by: Miguel Ojeda <ojeda@xxxxxxxxxx>
> > Signed-off-by: Miguel Ojeda <ojeda@xxxxxxxxxx>
> 
> Reviewed-by: Kees Cook <keescook@xxxxxxxxxxxx>
> 
> Does someone want to commit to taking these "prereq" patches? These
> clean-ups are nice even without adding Rust.

Qouting Message-ID: <CANiq72mXDne_WkUCo2oRe+sip7nQWESnouOJrcCYzyJMkG8F6A@xxxxxxxxxxxxxx>
https://lore.kernel.org/lkml/CANiq72mXDne_WkUCo2oRe+sip7nQWESnouOJrcCYzyJMkG8F6A@xxxxxxxxxxxxxx/
Miguel Ojeda, 2022-08-05: 
| > And I think that this patch and all other "rust" kallsyms patches
| > allready should have been accepted in the v3 or v5 series.
| 
| Yeah, it could be a good idea to get the prerequisites in first.
| Let's see if the patches get some Reviewed-bys

Now that there is a 'Reviewed-by: Kees Cook <keescook@xxxxxxxxxxxx>'


Regards
Geert Stappers
In an attempt to help making Rust for Linux happen.
-- 
Silence is hard to parse