Re: [PATCH] dt-bindings: spi: renesas,sh-msiof: Fix 'unevaluatedProperties' warnings

[Lad, Prabhakar]

Hi Krzysztof,

Thank you for the review.

On Tue, Aug 16, 2022 at 10:45 AM Krzysztof Kozlowski
<krzysztof.kozlowski@xxxxxxxxxx> wrote:
>
> On 16/08/2022 11:38, Lad Prabhakar wrote:
> > With 'unevaluatedProperties' support implemented, there's a number of
> > warnings when running dtbs_check:
> >
> > arch/arm64/boot/dts/renesas/r8a77951-ulcb-kf.dtb: spi@e6e90000: Unevaluated properties are not allowed ('power-domains', 'resets' were unexpected)
> >       From schema: Documentation/devicetree/bindings/spi/renesas,sh-msiof.yaml
> >
> > The main problem is that SoC DTSI's include power-domains and resets
> > property, whereas the renesas,sh-msiof.yaml has 'unevaluatedProperties:
> > false'. So just add optional power-domains and resets properties.
> >
> > Signed-off-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@xxxxxxxxxxxxxx>
> > ---
> >  Documentation/devicetree/bindings/spi/renesas,sh-msiof.yaml | 4 ++++
> >  1 file changed, 4 insertions(+)
> >
> > diff --git a/Documentation/devicetree/bindings/spi/renesas,sh-msiof.yaml b/Documentation/devicetree/bindings/spi/renesas,sh-msiof.yaml
> > index 5de710adfa63..7bd86cf876f1 100644
> > --- a/Documentation/devicetree/bindings/spi/renesas,sh-msiof.yaml
> > +++ b/Documentation/devicetree/bindings/spi/renesas,sh-msiof.yaml
> > @@ -69,6 +69,10 @@ properties:
> >    clocks:
> >      maxItems: 1
> >
> > +  power-domains: true
> > +
> > +  resets: true
>
> No. For both you need maxItems (or describe the items).
>
Agreed, I will fix it and send a v2.

Cheers,
Prabhakar