Re: [PATCH v5 3/5] vduse: Support using userspace pages as bounce buffer

[Yongji Xie]

Hi Mike,

On Fri, Aug 19, 2022 at 2:01 PM Mike Galbraith <efault@xxxxxx> wrote:
>
> Greetings,
>
> On Wed, 2022-08-03 at 12:55 +0800, Xie Yongji wrote:
> >
> > diff --git a/drivers/vdpa/vdpa_user/iova_domain.h b/drivers/vdpa/vdpa_user/iova_domain.h
> > index 2722d9b8e21a..4e0e50e7ac15 100644
> > --- a/drivers/vdpa/vdpa_user/iova_domain.h
> > +++ b/drivers/vdpa/vdpa_user/iova_domain.h
> > @@ -14,6 +14,7 @@
> >  #include <linux/iova.h>
> >  #include <linux/dma-mapping.h>
> >  #include <linux/vhost_iotlb.h>
> > +#include <linux/rwlock.h>
>                    ^^^^^^^^
>
> Erm, that should be spinlock.h.
>
> #ifndef __LINUX_RWLOCK_H
> #define __LINUX_RWLOCK_H
>
> #ifndef __LINUX_SPINLOCK_H
> # error "please don't include this file directly"
> #endif
>
> This belated comment inspired by PREEMPT_RT build meeting the above :)
>

Thank you for pointing it out! I think Sebastian had sent a patch [1] to fix it.

[1] https://www.spinics.net/lists/linux-virtualization/msg58136.html

Thanks,
Yongji